Thanks @Heng Sin Low

is this by sign logic always the safe thing to do ? perhaps a potential problem with reversal ?

Well, I really don’t need this, this was deprecated 10 years ago and I still haven’t found the case where both accounts would be required.

I reopened this because @Steven-Adaxa suggested it in IDEMPIERE-5322, and is “harmless” because if I want to keep using just one account, I simply need to fill both accounts equal.

Reading the code I think this is barely used, and as you suggest when used it can have problems with reversals, I think that was probably the case why we wanted to deprecate it at first place.

Re-reading the original ticket https://idempiere.atlassian.net/browse/IDEMPIERE-376, I see there were reported issues, I wrote there: “The reasoning behind this change is that allowing two accounts for charges is opening doors for errors (there are several documented errors caused by this, for example reversing a doc and using wrong account, or when you make a credit memo copying the invoice lines, etc).”

In the ticket is also pointed this issue: https://sourceforge.net/p/adempiere/discussion/611161/thread/34337fe0/

Re-reading what @Steven-Adaxa suggested:

If you are using Counter Docs and you raise a sales invoice in Head Office to your Subsidiary (say for rent, interest etc) then this needs to go to a revenue account. The generated AP invoice in the Subsidiary needs to book the values into the expense accounts … so you need the two Accounts on a single Charge to support this standard functionality. Perhaps it should be ‘un-deprecated’.

I think that’s a problem with charges, but it can be easily solved using products, or using GL Distribution. So, I tend to think is OK to keep the two charge accounts deprecated.

WDYT?

Regards,

Carlos Ruiz

@Heng Sin Low wrote:

is this by sign logic always the safe thing to do ? perhaps a potential problem with reversal ?

Pull request https://github.com/idempiere/idempiere/pull/1379 basically reverting (manually the parts required) the commit https://github.com/idempiere/idempiere/commit/1302d6b348dcebf04505782bdf7815f279631945