Results of Triage:

1 - the idea seems really useful for some use cases

2 - the classes are obsolete, cannot be applied straight to current classes to peer review

3 - the PDF explains clearly the changes required, but the changes described are done for all columns with type Amount/Cost+Prices, not as suggested to restrict just for print format elements marked as "IsDisplayCurrencyPrecision" - I think that's necessary, as is necessary to restrict that per print format item case, and not covering all the amount fields (see the attachment OrderDetail.png for an example where this is undesired effect)

4 - please feel free to reopen with pull request if there is an implementation using the AD_PrintFormatItem.IsDisplayCurrencyPrecision suggestion

Regards,

Carlos Ruiz

Hi Carlos.
Sorry to keep you waiting.

I had a happy idea.
Please add "IsDisplayCurrencyPrecision" column at "AD_PrintFormat" Table.
"IsDisplayCurrencyPrecision” column is flag that make a judgment to display currency precision or not .
When “IsDisplayCurrencyPrecision” column is “Y”, display currency precision at report.

I rewrote next the attachment file.

Apply_currency_precision_to_report.zip(PDF file)
LayoutEngine.java
ReportEngine.java

Please confirm that once more.
Please review that one more time.

If it is OK,I want you to apply my idea to repository.
It is very useful for Japan. And I think useful for other country too.
And,I will be very happy to contribute to the community.

Thank you for reading.

Hi Carlos.
On my side, I am really sorry.
I seemed to misunderstand it a little.
But I understand what you want to say now.
I agree with you.

I think also it is very important that currency precision display at tabular report consistency.
tabular report can download data. And the data may be analyzed by other application.
I think consistency of currency precision in tabular report is very important.

I have just a idea.
I think better,if iDempiere user can select "display same currency precision in tabular report for consistency" or "display currency precision each currency in tabular report".

I think hard from now on about how to implement this idea.
So let me suggest it again if I can do it.

And Please do discussion at community about currency precision.

I sincerely thank you for your polite and thorough response.
I am a beginner at English, so I sorry that my understanding is bad.

Sorry Hagiwara, I forgot to mention that:

• I temporarily fixed "Order Detail" (is broken at this moment)

• changed the GrandTotal column to Amount to verify the consequence of that

• set EUR currency to show zero decimals

That was in order to verify the consequence of having multiple lines in a tabular report with different precision.

The result is the attached OrderDetail.png - which I think doesn't seem good.

In form reports there's no problem as all the document just can have one currency.

But in tabular reports there is a problem each line can have a different currency (and consequently a different precision)

Regards,

Carlos Ruiz

Hi Carlos.

Thanks for your review and patch.
I am very glad to contribute iDempiere community.
And I am very happy to receive your review too.

Tabular reports may not need to apply currency precision usually.
Because tabular reports is used by manager or staff.not for customer.

But in case of tabular reports that is contained by "Form Report" is need to apply currency precision in Japan.
Because tabular reports that is contained by "Form Report" is for customer.
Japanese is very sensitive and serious, you know.
*please see attachment file:"formReport.jpg"

Please do discussion at community.

About your attachment file:The matter that the EUR is not displayed with the decimal point second place.
I think this cause is because display type(reference) of "Grand Total" column at RV_OrderDetail view is type of "number".
If you change display type of "Grand Total" from "number" to "amount", I think no problem.
Please check on that.

I wish to apply currency precision to report.Especially "Form Report" .
It is very useful for Japan. And I think useful for other country exclude the countries that currency precision is decimal point second place.
Please add me if possible when do discussion at community.
And please do discussion at community about too.

Thank you for reading.
And Sorry for my weird English.