Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

View find result from User Preference is not taken into account (e.g. Always In Grid View)

Description

When user set “View find result” option to “Always in Grid View” in it’s User Preferences it is expected that all results are displayed in Grid view after search query modal closes, regardless of “Single Row Layout” option in Tab configuration (in that case user can leave it to “Default”).

After investigating code i find out that “getViewFindResult" method from X_AD_UserPreference isn’t used anywhere. I propose adding logic to check this value in isSingleRow method of GridTab class.

Environment

All environments

Attachments

3
  • 25 Oct 2024, 12:00 PM
  • 25 Oct 2024, 11:41 AM
  • 25 Oct 2024, 07:59 AM

Activity

Show:

Milos R October 30, 2024 at 10:43 AM

Heng, I fixed this, now grid is only opened when find window closes

Heng Sin Low October 29, 2024 at 3:24 AM

hi , the help text for “View find result” user preference say “Does the system must switch to grid mode after the Find panel closes”. The preference should only affect the view after closing of the find dialog but your changes does affect the initial view of the window as well (for e.g Sales Order window).

Milos R October 28, 2024 at 8:58 AM

Hi Heng, I was looking for such documentation, but didn’t manage to find it. Thanks. Did create new pull request.

Heng Sin Low October 27, 2024 at 3:16 AM

hi , your pull request is wrong, please follow the workflow documented at https://wiki.idempiere.org/en/Fork_and_Branch_Git_Workflow

Milos R October 25, 2024 at 5:34 PM

All right, now I see, onFind is triggered only on button click, via doOnClick, this is not great solution, that’s why it isn’t triggered first time, there should be an event which fires when find dialog is opened, regardless of button press. Will take a look tomorrow.

Fixed

Details

Assignee

Reporter

Components

Fix versions

Affects versions

Priority

Created October 25, 2024 at 7:59 AM
Updated December 2, 2024 at 2:30 PM
Resolved November 2, 2024 at 8:27 AM

Flag notifications