Messages added, ready for review

Ah, and by the way, we have a lot of code concatenating messages, but that is a bad practice, it doesn’t work well with right-to-left languages

Right @Nicolas Micoud - specific messages are always better for usability because it leads the user to the solution.

Hi,

I've updated PR in order to add checks on BankTransfer, DunningLine and Request.
I also change the check for BankStatement to consider all statuses.

About PaymentTransaction, I do not use that, so I need advice.
Should I just check with something like "select 1 from c_paymenttransaction" ?

I have not created AD_Message as my question was not clear. And I'm not sure about your answer Carlos.
So in order to be sure/extra sure, which kind of message should I create :
- Option1 (which I called "specific") : eg UnableReactivatePaymentIsOnBankStatementLine, UnableReactivatePaymentIsPartOfBankTransfer
- Option2 (which I called "generic") : eg UnableReactivate, PaymentIsOnBankStatementLine, PaymentIsPartOfBankTransfer (m_processMsg will be UnableReactivate + PaymentIsOnBankStatementLine)

Thanks

hi,
not too much time to review bellow thread, but sharing my thoughts:
- we check first does allocation exists i yes, then simple - return message first cancel your allocation
- if the payment has payment transaction we assume it is POS - then we denied to reactivate - because it part of stack of docs - and was sent to fiscal or bank.
- we are didn't check anything against bank statement - if we generate payments - we simple allow reactivate them (if not allocated.)

n