Hi team! I reverted the ‘small UX improvement’ commit then, + 1 addition: all labels are now aligned right (Serial No, Guarantee Date, Description…)

Hi @Heng Sin Low - I installed the pull request in https://test-feature.idempiere.org:3243/webui/

This is the old vs new (test-oracle vs test-feature):

New ASI:

• test-oracle - the New Record toggle makes the fields editable or read-only - there is not a New button

• test-feature - the button New Record does nothing, as it has a save icon is confusing for users because the record is really saved with the OK button below

Open

Edit ASI:

• test-oracle - the Edit Record toggle makes the fields editable or read-only - there is not a New button

• test-feature - the button Edit Record does nothing, the record is simply not editable at all

Open

So, my suggestion, simply revert the part changing the flags to buttons, for me the other changes are OK (the added scrollbar is necessary).

Regards,

Carlos Ruiz

@Norbert Bede , the “Edit” checkbox to button change is a bad one. The “Edit” checkbox just act as a toggle between view and edit mode, you change it to a push button but it still just act a toggle. Also, the change of the button’s icon to “Save” icon when it is in edit mode doesn’t communicate the mode change effectively and just confuse user into thinking it as a “Save” button to save changes made (when effectively, it is just a toggle to switch back to view mode). If you prefer an icon button look, you should use toolbarbutton that support toggle mode (setMode(“toggle”)) instead of a normal push button (the change of icon when it is in edit mode is not needed). Note that for consistency of look, if you use toolbarbutton for “Edit Mode” toggle, you should use toolbarbutton for “New Record” as well.

@Carlos Ruiz , I can’t reproduce your “New button doing nothing” issue below, can you clarify what’s the test case for that ? Bug aside, the “New” button should be just fine UI wise since that’s just a replacement for the existing “New Record” button.

Yes, the lack of scrolling is a bug, because the user cannot use the dialog properly.

hi,

@Carlos Ruiz so you suggest revert 2nd commit and improve only scrolling or this is also not affordable - we keep it as customisation.

norbert