MWFActivity.saveError: SaveError - Update return 0 instead of 1

Description

The next error repeatedly returns on our production but also I check test.idempiere.org logs in many log files. In my experience server many times should crash after this entry appear in the logs.

extracted from:
https://test.idempiere.org/idempiereMonitor?Trace=/opt/idempiere-server/log/idempiere.2021-01-07_0.log

Environment

8.2 2021-01-07

Activity

Show:

Carlos RuizMarch 10, 2021 at 10:28 AM

Sure, if can come up with a pull request, I’ll gladly peer review it.

Regards,

Carlos Ruiz

Norbert BedeMarch 10, 2021 at 10:04 AM

Thanks Yes that is what suggested (checking the existence of the record before the update.). we tried to find solution, but cant get it work. Would be reasonable to fix this error.

We have many logs daily minimally 20-30 use cases. then struggling is this real error, mainly where node CPU is being too high (standard avg 10% in such cases climb to 50-70% - not sure caused by this but in 99% this type of log exists when alarm hit treshold. )

norbert

Carlos RuizMarch 10, 2021 at 9:56 AM

Hi - this message is caused by the fix in

When completing multiple documents sometimes there is a chain of transactions, when one of the “child” documents fail, the transaction is rolled back, but still the “parent” document tries to update activity and event audit and fails (because it was rolled back) - writing that message in the logs.

I could be wrong, but from what I understand the message is harmless. Maybe it can be improved to be managed better, like checking the existence of the record before the update.

Regards,

Carlos Ruiz

Details

Assignee

Reporter

Priority

Created March 9, 2021 at 4:49 PM
Updated October 16, 2023 at 2:31 PM