Some problems of sort at window before save.

Description

I found that there are some problems of sort at window before save.
I think that We need discussion to fix these problems.

I think that to fix these problems, we had better save before sort.
But, I don't know this idea is best or not. I think better than now.
grinning face with big eyes

Please tell me if anyone have a more better idea.

How to Reproduce

Step1: Please open Sales Order window. And display all record at Sales Order window by click search icon. like a step1.png image.

Step2: Please Add new record. and display grid view like a step2.png. Be careful not to save it.

Step3: Please sort by click a column (For example Document No column). Then the bottom line will be displayed as GridTabLoadTimoutError. Ref:step3.png [Problem No1]

Step4: Please go to last record by click last record bottom like a step4-1.png. Then some record will disappear like a step4-2.png [Problem No2]

Step5: Please reopen Sales Order Window. And display all record at Sales Order window by click search icon. like a step1.png image.

Step6: Please go to select last record. And add new record at last row. and display grid view like a step6.png. Be careful not to save it.

Step7: Please sort by click a column (For example Document No column). Then the bottom line will be displayed as GridTabLoadTimoutError.And Please select the record one above it. Then, displayed error of index out of bounds. Ref:step7.png [Problem No3]

And other case, Edit record and sort before save, Then the edited data will be restored. [Problem No4]

I confirmed at https://test.idempiere.org/ too.

I think that we can fix these problems by saving before sort.
Please tell me if anyone have a more better idea.

Best regards

Environment

None

Attachments

8
  • 21 Jan 2021, 04:13 PM
  • 21 Jan 2021, 04:13 PM
  • 21 Jan 2021, 04:12 PM
  • 21 Jan 2021, 04:12 PM
  • 21 Jan 2021, 04:11 PM
  • 21 Jan 2021, 04:10 PM
  • 21 Jan 2021, 04:10 PM
  • 21 Jan 2021, 04:05 PM

Activity

Show:

Hideaki Hagiwara January 24, 2021 at 12:53 PM

Hi, Heng Sin.
Thank you for reply.

I think your ideal is right.
I agree your ideal.
:-D

I would like to try to recreate pull request again in accordance with your ideal.

best regards.

Heng Sin Low January 24, 2021 at 10:21 AM

Since sort doesn’t actually making any changes to the data, ideally the currently focus row shouldn’t change after sort and still maintain its state.

Fixed

Details

Assignee

Reporter

Components

Fix versions

Affects versions

Priority

Created January 21, 2021 at 3:57 PM
Updated March 1, 2021 at 12:17 PM
Resolved January 25, 2021 at 3:45 PM

Flag notifications