Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Remove org.adempiere.report.jasper.webapp

Description

  1. Remove org.adempiere.report.jasper.webapp project

  2. Move standalone.jrxml to org.adempiere.report.jasper/test

  3. To allow the hosting of jasper report file using any web server, change the retrieval of md5 to reportfile.md5, i.e if report file is standalone.jrxml, md5 for the report file would be standalone.jrxml.md5 (similar to maven, etc)

  4. Change md5 hash from base64 to hex which it is more commonly use (maven, default of linux md5sum, etc).

Environment

None

Activity

Show:

Carlos Ruiz May 6, 2020 at 9:55 AM

Hi , tested the pull request and worked fine.

Three more changes suggested:

1 - Remove also the plugin org.adempiere.report.jasper.fragment.test - it's dependent on this and is showing error

2 - Remove also reference in MANIFEST.MF on webstore:
https://github.com/idempiere/idempiere-webstore/blob/master/org.adempiere.webstore/META-INF/MANIFEST.MF#L7

3 - I suggest adding the next lines in ReportStarter.getRemoteMD5, just before the "return hash" line:

String hash = new String(baos.toByteArray()); int posSpace = hash.indexOf(" "); if (posSpace > 0) hash = hash.substring(0, posSpace); return hash;

This makes the verification compatible with files generated using md5sum tool from command line.

Regards,

Carlos Ruiz

Fixed

Details

Assignee

Reporter

Components

Priority

Created May 6, 2020 at 5:39 AM
Updated July 1, 2020 at 7:52 PM
Resolved May 6, 2020 at 12:55 PM

Flag notifications