Add NVL PostgreSQL function

Description

  1. Add PostgreSQL pl/pgSQL implementation of “NVL” function.

  2. The initial idea of replacing “NVL” with “Coalesce” is drop after it cause compatibility problem with Oracle (inconsistent datatype error for Coalesce(<nvarchar column>,<string literal>)).

Environment

None

Activity

Show:
Carlos Ruiz
March 13, 2020, 10:06 AM

The change from NVL to COALESCE affected badly our oracle installation.

Test case:

The log shows 13 errors like:

Practically all windows are broken.

I think about two possible fixes:

1 - Revert the java part of this commit to restore back using NVL for oracle.
2 - implement the changes on to change all NVARCHAR columns (3395 columns in core seed, this is a big change and still any implementation will need to fix all their custom tables using NVARCHAR

I think better go for option 1.

, WDYT?

Heng Sin Low
March 13, 2020, 10:16 AM

Hi , yes, needs to goes back to nvl. If you have time, you can goes ahead to revert that, otherwise I will do it early next week.

Carlos Ruiz
March 13, 2020, 10:34 AM

Ready, committed the partial revert.

Carlos Ruiz
August 6, 2020, 1:27 PM

In theory, because of - this would not be required anymore - but anyways is harmless to have the NVL function.

Assignee

Heng Sin Low

Reporter

Heng Sin Low

Labels

None

Tested By

None

Components

Fix versions

Priority

Major
Configure