Counter Document can not create at Order and Invoice.Probably it is influence of IDEMPIERE-1597.

Description

Hi,All.
My name is Hideaki Hagiwara in Japan.

I tried to create Counter Document at Order and Invoice.
But I can not create Counter Document with "Error: : Price list cannot be changed because the invoice contains product lines" message.

I think that it may be influence of IDEMPIERE-1597.

I made a patch.
But I do not know whether this patch is best or not.
Please check my patch.

I think that is good improvement.
So, I think that I should change a timing to set Price List in Counter Document.

Thank you for reading.
And sorry for my poor English.

Environment

None

Activity

Show:
Carlos Ruiz
March 13, 2014, 1:16 AM

Thanks , the attached patch contains too many space and tab changes that makes too difficult the peer review.

In order to ease the peer review a patch must be focused just on the lines required to be changed. I mean, it's very difficult to realize the collateral impact when almost the full MOrder class appears as changed - but in reality the changes are just in two points of the class - the rest are tabs or spaces.

I'm fixing the patch Counter_Document_can_not_create_CLEAN.patch for peer review

萩原秀明
March 13, 2014, 3:26 PM

Dear Carlos:

I'm very sorry to have troubled you so much.
I mistook that I have included a part changed automatically formatted by Eclipse in patch.
I set it so that Eclipse did not do automatically format.
And I revised the patch which I posted before.

I think that I can make patch correctly from now on.
Thank you very much for letting me know. And Please forgive me.

Thanks in advance.

Carlos Ruiz
March 13, 2014, 4:00 PM

your finding, your screenshots and your patch were so valuable that we just must be thankful about you, I'm glad you took the recommendation positively. Let's keep doing this the best ERP in the world!

Assignee

萩原秀明

Reporter

萩原秀明

Labels

Tested By

None

Time tracking

1h

Components

Priority

Critical
Configure