Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Reversed Allocation document has wrong TrxDate

Description

I created an invoice and a payment with a TrxDate in an not existing period (last year). The acctDate was today so both documents were posted and ok. The Allocation was created and posted and ok also.

Then I tried to reverse the payment. I got an error "period closed" for documenttype "allocation" and could not reverse the payment.

I searched the code and found that there are four codepaths to create an allocation from an payment in MPayment.allocateIt(). This means I found four times "new MAllocationHdr(...". For two codepaths there was a line to correct the trxDate entered by Carlos Ruiz with this commit: https://bitbucket.org/idempiere/idempiere/commits/24d189fcd7c1

For the other two codepaths (one belongs to payment reversal) there is no such line. I think these two should be added. I don't know why Carlos did not correct all four so I want to ask here.

Environment

None

Attachments

1

Activity

Show:

Thomas Bayen December 18, 2013 at 11:06 AM

Your version works and is - as always - better thought than mine. Thanks!

For the records: We interfered with commit 1e85264 from HengSin (solving tracker 1003528 - whatever that means), but I think you solved it the right way.

Carlos Ruiz December 17, 2013 at 5:27 PM

Thanks Thomas, I committed a slightly different version - can you please check?

Thomas Bayen November 15, 2013 at 4:59 PM

This is how you can reproduce the bug (done on demo.idempiere.com in GardenWorld):

a) Create an "Invoice (Customer)" with a "Date Invoiced" in Year 2000 (no guilty period) and "Account Date" today (in a guilty period) for some GPartner (Joe Block) and with one line and some product (Oak Tree). Complete this invoice.

b) Create an "Payment" with Document Type "AR Receipt". Set "Transaction Date" to 2000 and Account Date to today (same as on the invoice). Set BPartner to Joe Block and the Invoice to the just created Invoice. "Complete" this Payment.

c) Go to the very same Payment and choose as action "Reverse - Correct".

You got an error message "Period Closed Date=2000-11-15 00:00:00.0, Document BaseType=Payment Allocation".

In my first try I created a wrong Reversal Payment without reversing the original Payment. This leads to a corrupt database (see https://groups.google.com/forum/#!topic/idempiere/I1lMw4WaxZk). I could not reproduce this on demo.idempiere.com. May be this is because I used the Swing Client during the first time. I have to investigate that if needed. But the issue is still an issue if it crashes the database or just does not allow to reverse the payment.

Thomas Bayen November 13, 2013 at 8:26 PM

This is my proposed patch.

Fixed

Details

Assignee

Reporter

Components

Affects versions

Priority

Created November 13, 2013 at 8:17 PM
Updated December 18, 2013 at 11:10 AM
Resolved December 17, 2013 at 5:27 PM