Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Over shipment handling

Description

Hengsin,

I found that https://idempiere.atlassian.net/browse/IDEMPIERE-1530 is covering over receipt to handle corrupted qtyOrdered. But similar case is qtyResereved. Should we make same implementation for qtyReserved based on overReceipt field?

Also I noticed that reservedQty is updated in loop for LineMA, If we move this out of this loop and make one update per shipment line, it will save some sql query cost in worst case scenario.

Please advise, can I proceed to make those changes?

With Regards,
Deepak Pansheriya

Environment

None

is duplicated by

Activity

Show:

Deepak Pansheriya June 17, 2014 at 11:27 AM

already fixed as ticket 1999

Heng Sin Low April 14, 2014 at 2:58 AM

If over shipment make wrong update of QtyReserved then yes, we should fix it.

Preferably every commit is keep as simple as possible, i.e it is best to split bug fixing and optimization into 2 separate commit. Will make peer review a lot easier.

Fixed

Details

Assignee

Reporter

Components

Priority

Created April 13, 2014 at 5:34 AM
Updated November 1, 2017 at 11:51 AM
Resolved September 12, 2017 at 10:32 AM