Improvement on locations

Description

  • automatic save when closing VLocDialog on a C_BPartnerLocation table (eg. Business Partner window)

  • new button next to location field (which opens VLocDialog)

  • "new" button on VLocDialog to add a location for the current business partner

  • VLocDialog title has BP name

Environment

None

Activity

Show:
Thomas Bayen
February 11, 2013, 3:37 PM

Hello Nicolas,

I integrated your patch with the JIRA Tracker ID as comment. I did a small change so that we do not have to change something outside of the swing directory.

https://bitbucket.org/tbayen/idempiere-swing/commits/fec3d762a8637cc8ed7b4ae297690e60a6584a1e

Your patches are not trivial and it was not everything obvious for me how it works. I propose to test this for a while as a peer review from the SMT members before closing this.

(Please register that I reorganized the swing repository's branch "best practice". I will explain this on the SMT Wiki page later.)

Thomas

Thomas Bayen
December 30, 2013, 2:09 PM

During Bug Triage I reviewed this issue. I created a patch for the actual iDempiere version and hope it works. After a hopefully short review phase we should get this into trunk as soon as possible.

Nicolas Micoud
January 2, 2014, 8:21 AM

Hi Thomas,

I've looked at your patch (i was not able to apply it so i had to integrate it manually) and it seems ok to me, except for the TO_ROUTE/TO_LINK part.
Those message were static and a fix was integrated there https://bitbucket.org/idempiere/idempiere/commits/a4f9110eb28d227e75d7dd337f2ade0fff4175f7/.
I think your sources were not updated to that point.

Regards,

Nicolas

Thomas Bayen
January 5, 2014, 1:23 PM

Thanks Nicolas. I reintroduced an old bug. Juggling with all these versions and patches mixed my mind up. Sorry! The new patch should clean integrate into the actual trunk.

Carlos Ruiz
March 4, 2015, 4:24 PM

Labeled as Potential Idea - closing because of lack of community interest

Assignee

Thomas Bayen

Reporter

Nicolas Micoud

Tested By

None

Components

Priority

Major
Configure