Implement expire after access policy for cache

@Heng Sin Low answered:

By right, key should never be null. Anyway, it is harmless to add that to CCache.get

Hi @Heng Sin Low

I think is because of this ticket that REST is throwing this error when executing the endpoint /api/v1/forms without parameters:
13:42:45.084===========> FormResourceImpl.getForms: Cannot invoke "Object.hashCode()" because "key" is null [182]

java.lang.NullPointerException: Cannot invoke "Object.hashCode()" because "key" is null

at java.base/java.util.concurrent.ConcurrentHashMap.get(ConcurrentHashMap.java:936)

at com.github.benmanes.caffeine.cache.BoundedLocalCache.getIfPresent(BoundedLocalCache.java:2179)

at com.github.benmanes.caffeine.cache.BoundedLocalCache.get(BoundedLocalCache.java:2174)

at org.compiere.util.CCache.get(CCache.java:400)

at com.trekglobal.idempiere.rest.api.json.filter.DefaultQueryConverter.convertStatement(DefaultQueryConverter.java:55)

at com.trekglobal.idempiere.rest.api.v1.resource.impl.FormResourceImpl.getForms(FormResourceImpl.java:68)

Line 55 on REST is:
ConvertedQuery cache = convertCache.get(queryStatement);

and queryStatement is null, the fix in REST is easy, but as is not failing in release-11 I think the fix maybe must be on CCache.get to return null when the key is null?

WDYT?

Yes, will be clear as well.

Hi @Heng Sin Low - about this:

For cache that doesn’t set maximum size and expire time, we should continue to use a simple ConcurrentHashMap.

are those ConcurrentHashMap also cleared with Cache Reset?