AD_Preference.PreferenceFor should support Forms
Description
Environment
Attachments
- 28 Aug 2023, 01:02 PM
relates to
testing discovered
Activity
Carlos Ruiz September 4, 2023 at 12:44 PM
Nicolas Micoud September 4, 2023 at 11:57 AM
@Carlos Ruiz ,
About we should also update the label of InfoWindow on the list used in AD_Menu - AFAIR, it is “Info” (and I think I used that as source), I think this won’t be so easy as X_AD_Menu.ACTION_Info is used in 7 places in the code.
It can also be used in plugins, so the change is not neutral, not sure if it worth the effort ; wdyt?
Nicolas Micoud September 4, 2023 at 11:41 AM
PR updated
and ticket created: https://idempiere.atlassian.net/browse/IDEMPIERE-5844
Nicolas Micoud September 4, 2023 at 10:35 AM
Hi @Carlos Ruiz
No bother,
I think this ticket can be just about adding stuff for forms.
I can create another one to fix missing columns/fields for InfoWindow. And I think, we should also update the label of InfoWindow on the list used in AD_Menu - AFAIR, it is “Info” (and I think I used that as source)
Carlos Ruiz September 4, 2023 at 10:34 AM
@Nicolas Micoud - please note also that mixing bug fix with new features is not a good idea, the bug fix is good for release-10 integration, but the new feature probably is not.
Because of that, maybe you can consider moving the scripts again to iD10 (sorry about that contradictory request) - or split the ticket in two.
Yes - no need to change the menu, just the new option