ESC Shortcut Closes Tab and Pop-up Window at Once

Description

Currently, the two shortcut-closing events (Events.ON_CANCEL and Events.ON_CTRL_KEY) are both listening for the ESC key for closing: Events.ON_CANCEL is implemented in popup windows (e.g. process modal dialog, lookup info window etc.), and Events.ON_CTRL_KEY is implemented for closing the whole tab. Because of this, if the USE_ESC_FOR_TAB_CLOSING SysConfig is set to 'Y', we get the following behaviour:

  • open Order Details

  • open the lookup of the Product field

  • press ESC (while the mentioned SysConfig is set)

  • the lookup and the whole tab is closed at once

  • expected behaviour: one press of the ESC key should close only the last child, closing the components one by one

This issue many times causes that the users need to reopen the accidentally closed tab.

Providing a video of the bug:

The second video shows, that the expected behaviour is works for the Events.ON_CANCEL event:

Mattermost thread (contains suggested solutions): https://mattermost.idempiere.org/idempiere/pl/yirwn1ns3fdsujanactsjhg4aa

Environment

None

Attachments

2
  • 18 Jul 2023, 07:29 AM
  • 18 Jul 2023, 07:28 AM

Activity

Peter Takacs 
September 11, 2023 at 12:47 PM

Reopening to provide an - I believe - trivial fix: https://github.com/idempiere/idempiere/pull/1997

Fixed

Details

Assignee

Reporter

Fix versions

Priority

Created July 18, 2023 at 7:28 AM
Updated November 1, 2023 at 11:07 AM
Resolved September 13, 2023 at 10:52 AM