Context parsing on process Parameter not considering tab no

Description

When launching process from line and process parmeter has default logic, it brings value from header instead of using from tab.

Environment

None

Activity

Show:

Heng Sin Low April 1, 2023 at 4:22 AM

This should be fixable by making ProcessParameterPanel as Evaluatee and adding the concept of parent Evaluatee to GridField. With ProcessParameterPanel as parent/first Evaluatee and Environment context as secondary Evaluatee, we allow value from ProcessParameterPanel’s editor to take precedence over same name field in calling GridTab.

Will create a PR base on this.

Deepak Pansheriya March 31, 2023 at 7:01 PM

agree with that the isEncrypted issue you reported is clear conflicting. We should have find way to give preferences to Process parameter over tab data.

One option may be Process parameter are given special prefix like we use +,# etc.

I am fine to revert this till we find better solutions and fix for null value too.

Carlos Ruiz March 31, 2023 at 6:54 PM

+

I don’t see how to solve this scenario.

I checked and it seems in core we just have it in this button, but I don’t see how to solve it.

Scenario is:

  • Table: AD_Column

    • Column: IsEncrypted

      • Process: Column Encryption

        • Parameters: Maximum Length and Test Value

Both parameters have DisplayLogic = @IsEncrypted@=Y

The IsEncrypted is a column in the table, and is also a name of the parameter.

Because of this ticket the value of the context tab takes precedence over the value of the parameter, and the display logic doesn’t work.

 

I’m proposing to revert the changes on this ticket, because this scenario can happen elsewhere, but it seems is uncommon. But also because there is another case proved that is broken (also not in core, but broke a customization in our customer).

And also this solution - as I understand from Deepak - was implemented to solve a case from liberomfg which also can have a different solution.

 

However, if you want to keep it I don’t have a problem, but we need to solve the Column Encryption issue, so:

one possible solution not reverting I can see is renaming the Process Parameter to something else:

IsEncryptedParam - and changing the process and the DisplayLogic to use the context variable IsEncryptedParam

 

WDYT?

Regards,

Carlos Ruiz

Carlos Ruiz March 24, 2023 at 9:05 PM

Solving found a problem with this implementation.

The “Not Encrypted” button is not showing the third and fourth parameters that are based on the first parameter DisplayLogic = @IsEncrypted@=Y

This is failing because the parameter has the same name as the field in the tab, and it must take precedence.

Note that in release-9 it was working fine, is just after the first commit here that failed.

/ - must we revert this until find a proper solution?

Deepak Pansheriya February 1, 2023 at 12:33 PM

Now I got why we have to add this logic. In Libero plugin,For Node field (AD_WF_Node_ID column) of Manufacturing workflows --> Activity --> Tools tab had default logic @1|AD_WF_Node_ID@.

This was working fine on Manufacturing workflow window.

Now we links workflow to formula master and bring above all 3 tabs under formula master. this cause level of tab to change for Node. which cause the default logic with tab not resolving.

 So I think better we resolve issue of why we getting 0 instead of null.

Fixed

Assignee

Heng Sin Low

Reporter

Components

Fix versions

Due date

Priority

Created January 3, 2023 at 7:16 AM
Updated May 1, 2023 at 5:40 PM
Resolved April 1, 2023 at 2:24 PM
Loading...