Improve default trx name (FHCA-3765)

Documented at:

https://wiki.idempiere.org/en/NF4.1_Monitor_Trx

https://wiki.idempiere.org/en/System_Configurator_(Window_ID-50006)#TRX_AUTOSET_DISPLAY_NAME

Hi @Heng Sin Low - due to your concern about performance the FH team did the research and suggested to change the code to use StackWalker instead of Throwable->getStackTrace.

I checked some articles in the internet and it seems that is much better for performance.

For example this article makes a comparison between the methods:

https://ionutbalosin.com/2018/06/an-even-faster-way-than-stackwalker-api-for-asynchronously-processing-the-stack-frames/

and concludes:

“when there is a strong need to synchronously process stack frames within the caller thread (i.e. business logic depends on it, hence it cannot be decoupled), StackWalker API offers better performance in comparison to Throwable::getStackTrace or Thread::getStackTrace APIs”

The pull request 1427 implements the suggested changes (I tested with WCtxHelpSuggestion.onSave which is one of the few places we still have unassigned displayName).

The feature is still disabled by default, and must be enabled using SysConfig TRX_AUTOSET_DISPLAY_NAME.

Regards,

Carlos Ruiz

hi @Carlos Ruiz , I’ve added my comments to the PR

Hi @Heng Sin Low

I created pull request 1407

I notice that this pull request makes unnecessary a lot of calls to Trx.setDisplayName - when we are setting just class and method name.

There are a few calls that add information, for example in PO where we add the ID to the display name.

Do you think is worthy to remove the unnecessary display name calls - or we simply leave them there?

Regards,

Carlos Ruiz