Refactoring and clean up of BOM Drop form

Description

Refactoring and clean up of BOM Drop form:

  • Move business logic and db code to org.idempiere.apps.form.BOMDrop in org.adempiere.ui project.

  • Minor layout improvement.

  • Fix rendering of variant component type (only child of selected variant should be visible).

  • Fix component type other than Component and Option is being render as Variant type.

  • Clean up variable and comments. Refine naming of some variables.

  • After save, prompt created document with link.

  • Add Unit Test.

Minor tweak of ProcessInfoDialog:

  • Deprecate a constructor that silently ignore 2 parameter.

  • Add AutoCloseAfterZoom flag. When set to true, auto close the dialog after user zoom/navigate to a document through Document Link.

Environment

None

Activity

Show:

Carlos Ruiz June 27, 2022 at 11:04 AM

It should be similar in production (production bom drop ?) where user select the configuration (variant, options) to produce

Agree, but there is not such feature at this moment, maybe could be possible to add in future the production document in BOM Drop, or integrate the BOM Drop button in the production header.

The default can’t be right in that it just includes all the option and variant bom lines

In addition to that, for create production to just includes all bom lines, that’s not correct by definition too for phantom bom component type.

I suppose this can be intended to add everything, and then the user goes and delete what is not needed, it doesn’t sound good anyways.

 

I think at some point of time there was a BOM Drop version that worked with variants/options/features, but it was lost, but maybe is easier just to add the missing code to your suggested pull request.

 

BTW, the changes to ProcessInfoDialog, especially this one:

Add AutoCloseAfterZoom flag. When set to true, auto close the dialog after user zoom/navigate to a document through Document Link.

are good, they deserve its own ticket I think, I feel all the dialogs with just one link can use this new autoclose feature by default.

Heng Sin Low June 27, 2022 at 8:01 AM
Edited

In addition to that, for create production to just includes all bom lines, that’s not correct by definition too for phantom bom component type.

Heng Sin Low June 27, 2022 at 7:49 AM
Edited

It should be similar in production (production bom drop ?) where user select the configuration (variant, options) to produce. The default can’t be right in that it just includes all the option and variant bom lines. of course, this is not a problem for some where they just keep variant as separate bom (I guess some would take that as simpler to maintain and simpler UI for user).

Carlos Ruiz June 27, 2022 at 6:51 AM

Not 100% sure - we would need to check with the mfg experts, but I think variants and options make sense in principle in the BOM Drop, where the user manually select the composition of the BOM.

In the places where the BOM is added automatically (like create production), somebody would need to select manually which variants/options to add, so it cannot be automatic.

Heng Sin Low June 27, 2022 at 1:53 AM

There’s no support of variant component type and feature in other form and processes of mfg-light (bom viewer, create production, etc).

Fixed

Details

Assignee

Reporter

Components

Fix versions

Priority

Created June 24, 2022 at 8:23 AM
Updated September 1, 2022 at 11:10 AM
Resolved July 7, 2022 at 1:12 PM

Flag notifications