Possible bug with uom conversion on invoice when create from shipment

Description

https://groups.google.com/g/idempiere/c/PQrtOjAiW8U/m/k5czuio_AQAJ?utm_medium=email&utm_source=footer

Steps to reproduce:

Change in system configurator ProductUOMConversionRateValidate to N

Change standar precision of unit EACH from 0 to 2

Create product 6packproduct with productuom 6-Pack

Create conversion 6-Pack to each on this product

Create purchase order 800003 and receipt 10000511 to add 10 6-Pack 6 dolar per product.



Create sales order 50001 with one line with  qty 2 , price 12 for each 6packproduct total 24

Create shipment  500000 with 2 lines firstline with 1 and unit 6-Pack and the second with 5 EACH

Create invoice  (customer) 100002 and it create it wrong with the second line with unit 6-Pack instead of EACH

Environment

None

Attachments

2
  • 26 Jul 2021, 06:25 PM
  • 22 Jul 2021, 10:27 PM

Activity

Show:

Angel Lara August 13, 2021 at 2:14 PM

Hi Carlos thanks for the feedback, i have created the new pull request using the procedure explained in the wiki. I hope is all good this time grinning face

 

https://github.com/idempiere/idempiere/pull/830

 

Thanks

Carlos Ruiz August 5, 2021 at 3:15 PM

Hi - thanks for the pull request, my comments:

  1. please don’t do pull request on master - the Fork and Branch Git Workflow suggest to create a feature branch, we usually use the Jira ticket as the branch name

  2. it seems the pull request is mixing a solution for another issue - that part about the bank account looks valid, but is necessary to open a new Jira describing the issue

  3. please fix those and I’ll proceed to test the pull request(s)

Regards,

Carlos Ruiz

Angel Lara August 4, 2021 at 10:33 PM

Carlos Ruiz July 26, 2021 at 8:24 PM

Hi - in principle it looks good - please create a pull request for testing.

Regards,

Carlos Ruiz

Angel Lara July 26, 2021 at 6:25 PM

hi, i upload our proposal solution, in this aproach we are keeping the unit from the in/out record and we are only converting the price of the item.

Fixed

Details

Assignee

Reporter

Fix versions

Priority

Created July 20, 2021 at 12:49 PM
Updated November 1, 2021 at 8:19 PM
Resolved September 9, 2021 at 9:21 PM

Flag notifications