Possible bug with uom conversion on invoice when create from shipment
Description
Environment
Attachments
- 26 Jul 2021, 06:25 PM
- 22 Jul 2021, 10:27 PM
Activity
Angel Lara August 13, 2021 at 2:14 PM
Hi Carlos thanks for the feedback, i have created the new pull request using the procedure explained in the wiki. I hope is all good this time
https://github.com/idempiere/idempiere/pull/830
Thanks
Carlos Ruiz August 5, 2021 at 3:15 PM
Hi @Angel Lara - thanks for the pull request, my comments:
please don’t do pull request on master - the Fork and Branch Git Workflow suggest to create a feature branch, we usually use the Jira ticket as the branch name
it seems the pull request is mixing a solution for another issue - that part about the bank account looks valid, but is necessary to open a new Jira describing the issue
please fix those and I’ll proceed to test the pull request(s)
Regards,
Carlos Ruiz
Angel Lara August 4, 2021 at 10:33 PM
pull request created: https://github.com/idempiere/idempiere/pull/815
Carlos Ruiz July 26, 2021 at 8:24 PM
Hi @Angel Lara - in principle it looks good - please create a pull request for testing.
Regards,
Carlos Ruiz
Angel Lara July 26, 2021 at 6:25 PM
hi, i upload our proposal solution, in this aproach we are keeping the unit from the in/out record and we are only converting the price of the item.
https://groups.google.com/g/idempiere/c/PQrtOjAiW8U/m/k5czuio_AQAJ?utm_medium=email&utm_source=footer
Steps to reproduce: