MRole.updateAccessRecords insert active records based on deactivated objects

Description

Environment

None

Activity

Nicolas Micoud
July 2, 2021 at 1:34 PM

done

Carlos Ruiz
July 2, 2021 at 12:45 PM

Yes - new pull request is fine

Nicolas Micoud
July 2, 2021 at 12:42 PM

Hi ,

I’ve made the changes to the scripts, but don’t know how to send them as the pull request is closed now.
Should I open a new one (IDEMPIERE-4860_2 ?)

 

And that’s right, is not a real bug as there is not access to deactivate object.
Is only to avoid filling tables with useless records.

Thanks,

 

Nicolas

Carlos Ruiz
July 2, 2021 at 10:37 AM

Hi ,

I think the commit is incomplete, the same changes must be added to:
migration/processes_post_migration/oracle/04_role_access_update.sql
migration/processes_post_migration/postgresql/04_role_access_update.sql

Otherwise, every RUN_SyncDB will insert those records anyways.

Also, one question, this is mostly cosmetic, right? It's marked as bug, but I think there is no bug here, the access record is added, but the menu doesn't show inactive entries, right?

Regards,

Carlos Ruiz

Fixed

Details

Assignee

Reporter

Fix versions

Priority

Created July 1, 2021 at 9:56 AM
Updated September 1, 2021 at 9:04 PM
Resolved July 5, 2021 at 7:06 PM