reactivating a warehouse order will reverse connected invoices.
Description
Environment
Activity

Martin SchönbeckJune 10, 2020 at 4:05 PMEdited
Hi ,,
the last days I thougth a bit about it and if it wouldn’t be so much change, I think the best solution would be to have it configurable at the document type level. So that a document type could be configured not to allow reactivation (or voiding, the next place where the problem arose) as soon as a certain stage is reached (completed shipment, completed invoice, paid invoice) and in case it is allowed to determine, which documents have to be reversed. But it would need further thinking, how to generalize the concept to make in bullet proof. So for the moment I’ld prefer to do the little step.
Regards,
Martin

Heng Sin LowJune 9, 2020 at 10:47 AM
Hi ,
I agree that it should be configurable for both request and I think the more common use case is do not allow the auto reverse of completed documents upon reactivation of order. Also, UI wise, it is not obvious to the user that the user have just reversed a shipment and invoice document by reactivating an order. Considering that in many organization, ordering and billing is handle by different individual, this is can be a pretty dangerous operation (not to mention it is disallow in some country and organization).
Regards,
Low
Carlos RuizJune 9, 2020 at 10:10 AM
Hi , can you please give us a hand here?
I would like to get your opinion on this:
Summarizing:
As documented here:
https://wiki.idempiere.org/en/Sales_Order_Types
Standard Order and Prepay Order doesn't reverse any document when reactivating
Warehouse Order creates shipments when completing - and reverse shipment and invoices when reactivating
POS/OnCredit Order creates shipment and invoice when completing - and reverse both when reactivating
's request is that warehouse orders must not reverse invoices because they were not automatically created.
's request is that orders must not be allowed to be reactivated when they have related documents.
I tend to agree with Martin's point - in a configurable way, but still have doubts about what would be the most correct approach - WDYT?
Regards,
Carlos Ruiz

Martin SchönbeckJune 2, 2020 at 6:45 PMEdited
Hi ,
I see your argument but it’s valid only as long as the inconsistent behaviour of warehouse orders is present. After correction of this only reactivation of POS-Orders (and on credit orders, which mainly work the same way) would reverse an invoice. And because POS-Orders always create an invoice, reactivation is always wrong in your country. So it can be disabled for all users for this type of orders.
Regards,
Martin
Hi ,
even in hundred years of usage it will be inconsistent that reativation of one type of orders reverses documents created by other processes while all other types only reverse documents created by completing this order. Of course there may be work arounds out there. But also may be reactivation of warehouse orders simply is a very seldom operation due to the type of the warehouse order itself. And to avoid problems for those who created their own business processes around it the MSysConfig entry was meant.
Regards,
Martin
Carlos RuizJune 2, 2020 at 6:31 PM
Ah ok , it makes sense in Colombia as there electronic invoice cannot be reversed, you need to issue a credit note instead.
Details
Assignee
Martin SchönbeckMartin SchönbeckReporter
Martin SchönbeckMartin SchönbeckPriority
Major
Details
Details
Assignee

Reporter

reactivation should reverse only those additional documents which were created by completing the reactivated document. Therefore warehouse orders should reverse only shipments, not invoices.
Idea to name the SysConfig entry: REACTIVATE_WH_ORDER_REVERSES_INVOICE. What to do if no entry present? Old behaviour or corrected behaviour?
See also: https://groups.google.com/forum/#!topic/idempiere/K1zupyuQ4j4