Remove hard coded modal dialog height

Description

Use css style that let browser do its work instead of using hard coded height in pixel.

Test:

  1. Log in as GardenWorld admin or user

  2. Open product window, search for product with Bill of Material = Yes

  3. Click “Verify BOM Structure” button

  4. Check the process modal dialog size is appropriate.

Environment

None

Activity

Show:
Carlos Ruiz
May 6, 2020, 8:54 AM

Hi , the change looks good on processes running from a button that fits in the screen.

If the dialog doesn't fit in screen then a scrollbar is shown, but for reports, the View/PrintFormat/Language/Summary fields are not visible.

But for processes running from menu is not.
For example the Initial Client Setup Process, the scroll bar is missing, so user cannot see the buttons and last fields, they can be reached just navigating there with Tab.

Also, the position of the buttons was moved from botton to up, for example running Cache Reset, the OK button was moved to top, and after running, the parameter button was moved even higher.

Regards,

Carlos Ruiz

Carlos Ruiz
May 6, 2020, 11:53 AM

Hi ,

There is still an issue when a report has many parameters.

In order to test that I set a button for the initial client process and marked it as report and the resulting screen looks like this:

Regards,

Carlos Ruiz

Heng Sin Low
May 6, 2020, 11:59 AM

Other than the fake example above, do we have an actual example of that in the system ?

Carlos Ruiz
May 6, 2020, 12:44 PM

Hi , I pushed the changes, tested before the change and this was not created by these changes, but it was the same before.

Curiously, when running on tablet/phone the fields are visible, is just on desktop mode and just for this process, for Financial Reports it was working fine too, with little resolution.

Regards,

Carlos Ruiz

Assignee

Heng Sin Low

Reporter

Heng Sin Low

Labels

None

Tested By

None

Components

Priority

Major
Configure