WTableDirEditor - missing public methods

Description

Environment

None

Activity

Show:
Carlos Ruiz
April 22, 2020, 8:09 PM

Hi , the change on was from public to protected (which sounds fine). But from private to public (as the patch here) sometimes is not a good idea.

Do you need those to be public? Or is protected enough?

Regards,

Carlos Ruiz

Nicolas Micoud
April 23, 2020, 4:57 AM

Hi ,

I only need the actionLocation.
For the patch, i set them public to make it consistent with WSearchEditor, but protected is fine.

Please find another patch, with protected.

Thanks,

Nicolas

Carlos Ruiz
April 29, 2020, 5:04 PM

Hi

WSearchEditor.actionQuickEntry is protected, not public.

Checking the patch ...

Nicolas Micoud
April 30, 2020, 4:44 AM

Hi ,

That's correct :-/
Sorry

Nicolas

Assignee

Nicolas Micoud

Reporter

Nicolas Micoud

Labels

Tested By

None

Priority

Major
Configure