Move Webstore out of core

Description

Move webstore from core to a new repository idempiere-webstore

Environment

None

Activity

Show:
Carlos Ruiz
May 3, 2020, 2:03 PM
Edited

When I generate the model classes for entitytype D still I_AD_UserMail shows "I_W_MailMsg cannot be resolved to a type" and same in X_AD_UserMail.

Still would require changing ModelGenerator class to generate just columns with entitytype applying the same filter as the third parameter?

And that could be a problem to generate model classes for plugins? Maybe a new parameter in the model generator?

Heng Sin Low
May 4, 2020, 3:04 AM
Edited

Hi Carlos,

I’ve added the filtering of column by entitytype to the generate model and interface code. I don’t think that could cause problem for plugins since you can include multiple entitytype for the generation of model class/interface, i.e the parameter of ‘D',’U','WSTORE' will translate to EntityType IN ('D','U','WSTORE') and that should cover the needs of plugins.

Regards,

Low

Carlos Ruiz
May 4, 2020, 5:43 PM

Hi , it doesn't work well.

I think we need different filter for tables than for columns.

These are the model generate that I execute on release time:

Step 1:
Folder = org.adempiere.base/src
Package = org.compiere.model
EntityType = D,EE05
TableName = %

Step 2:
Folder = org.adempiere.base/src
Package = org.eevolution.model
EntityType = EE01,EE04,EE02
TableName = %

Step 3:
Folder = org.adempiere.base/src
Package = org.compiere.model
EntityType = D
TableName = 'AD_AllUsers_V','AD_AllClients_V'

The views 'RV_WarehousePrice','RV_BPartner' are included in a hardcoded way in step 1.

These 3 steps are needed because we still have in core all the libero tables with different entity types, and many core 'D' tables have columns with libero entity types.

So, with this change the Step 1 is broken, because all the columns with libero entity type are not included, if I add the libero entity types in step 1 - then it will create X_ classes in the wrong package.

I think it would be easier simply to inactivate this column in dictionary - and activate it in a 2pack in the webstore plugin.

Regards,

Carlos Ruiz

Heng Sin Low
May 5, 2020, 12:36 AM

Typical case of “if a bug exists long enough, it is a feature”.

Will come back to this later, moving on for now. If you want to make the changes you mention above, feel free to go ahead with it.

Carlos Ruiz
May 5, 2020, 10:00 AM

> Typical case of “if a bug exists long enough, it is a feature”.

I would say: we are still suffering from the poor decision of allowing to push libero into core

Assignee

Heng Sin Low

Reporter

Heng Sin Low

Labels

None

Tested By

None

Components

Fix versions

Priority

Major
Configure