WAutoCompleterCity should retrieve only active cities

Description

Hi,

I've added cities at System level.
To avoid duplicates, I deactivate cities of client level.
Anyway, all cities (System/Client) are still available because the IsActive criteria is not use in the query.

Environment

None

Activity

Show:
Nicolas Micoud
January 16, 2020, 9:33 AM

Hello ,
Please find a patch that use the IsActive criteria when searching a city.

Regards,

Nicolas

Carlos Ruiz
January 16, 2020, 11:32 AM

Thanks , applied the patch in 7.1
https://github.com/idempiere/idempiere/commit/8d6ef9aa187d47a521c9145e894a3aaa7059c4fc

There is something weird with your patches, they never apply cleanly from command line, I always need to work them on eclipse, or manually.

I suspect is because of EOL difference between windows and linux.

Regards,

Carlos Ruiz

Nicolas Micoud
January 16, 2020, 1:40 PM

Hi ,

The patch is done on Windows, using TortoiseGit (Commit and then generate the patch).

2 options :
#1: use Windows
#2: could you send me a (small) patch generated from your environnent( a little change on MTest for instance), so I can try to generate the same

Thanks,

Nicolas

Carlos Ruiz
January 16, 2020, 1:40 PM

you must be joking to recommend windows over linux

Nicolas Micoud
January 16, 2020, 1:46 PM

indeed

Assignee

Nicolas Micoud

Reporter

Nicolas Micoud

Labels

Tested By

None

Fix versions

Priority

Major
Configure