ORACLE - Update datatype NVARCHAR2 to VARCHAR2

Description

See https://groups.google.com/forum/#!topic/idempiere/itJ2JPOfvg8

– from comment below:
One warning reviewing the code.

In case this ticket is implemented there are two occurrences of COALESCE..TO_NCHAR that must be taken care:
MProjectType.getSqlBarChart:240
MRequestType.getSqlBarChart:429

Environment

None

Activity

Show:
Carlos Ruiz
August 6, 2020, 2:04 PM

Hi , , can you please take a look at the pull request 207

I did tests and everything was running fine in the oracle with all the columns as VARCHAR2.

The ticket seems unnecessary now, but harmless to have it.

Regards,

Carlos Ruiz

Hiep Lq
November 11, 2020, 10:55 AM

i has this issue guess reason by this ticket

because i apply some commit (not full) of this ticket i also hasn't test database to check update latest
can you confirm it's fixed on latest (in case it's issue by this ticket)?

Carlos Ruiz
November 11, 2020, 11:26 AM

Thanks

I don't see that error in my DB - but seems there can be something wrong.

Reopening this ticket to investigate - there is probably something missing here - in my test database I see the columns SERNOCHARSOVERWRITE
LOTCHARSOVERWRITE
LOTCHAREOVERWRITE
SERNOCHAREOVERWRITE
are still NCHAR in the table M_ATTRIBUTESET

Hiep Lq
November 12, 2020, 4:01 AM

on my database LOTCHARSOVERWRITE, LOTCHAREOVERWRITE is changed
on code, only first commit of is apply, it hasn't migrate sql not sure what commit did that change

Carlos Ruiz
November 12, 2020, 9:00 AM

Assignee

Carlos Ruiz

Reporter

Nicolas Micoud

Labels

Tested By

None

Fix versions

Priority

Minor
Configure