Switch LDAP type by System Configuration
It's better to switch in System configuration.
// For OpenLDAP uncomment the next line
// StringBuffer principal = new StringBuffer("uid=").append(userName).append(",").append(domain);
StringBuffer principal = new StringBuffer(userName).append("@").append(domain);
Thanks , I agree with this patch - but I think it would be better to make the system authentication pluggable.
I mean, in principle, there would be two or three authentication methods: idempiere, ldap, openldap
But I think we need to add the possibility for more authentication methods as a pluggable module, and make the configuration based on tenant, not just system.
I have modified it and export the patch.
Switch LDAP type by System Configuration with LDAP_TYPE keyword. "openldap" stand for OpenLDAP, and "standard" is default value. Empty or null is also assigned to stantand type.
IS_OPENLDAP should be LDAP_TYPE
should has a MSysConfig record with LDAP_TYPE=standard
also has a description to that record (standardldap, openldap is supported empty or null mean standard)
I upload the patch file.
from your comment, uncomment and change some code for openldap, so how about other *ldap implement?