Switch LDAP type by System Configuration

Description

It's better to switch in System configuration.
// jjanke@compiere.org
// For OpenLDAP uncomment the next line
// StringBuffer principal = new StringBuffer("uid=").append(userName).append(",").append(domain);
StringBuffer principal = new StringBuffer(userName).append("@").append(domain);

Environment

package org.compiere.db;
class LDAP

Activity

Show:
Carlos Ruiz
January 14, 2019, 3:49 PM

Thanks , I agree with this patch - but I think it would be better to make the system authentication pluggable.

I mean, in principle, there would be two or three authentication methods: idempiere, ldap, openldap

But I think we need to add the possibility for more authentication methods as a pluggable module, and make the configuration based on tenant, not just system.

Regards,

Carlos Ruiz

Ray Lee
January 12, 2019, 5:17 AM

I have modified it and export the patch.
Switch LDAP type by System Configuration with LDAP_TYPE keyword. "openldap" stand for OpenLDAP, and "standard" is default value. Empty or null is also assigned to stantand type.

Hiep Lq
January 9, 2019, 2:48 AM
Edited

IS_OPENLDAP should be LDAP_TYPE

should has a MSysConfig record with LDAP_TYPE=standard

also has a description to that record (standardldap, openldap is supported empty or null mean standard)

Ray Lee
January 8, 2019, 9:40 PM

I upload the patch file.

Hiep Lq
January 8, 2019, 5:19 AM

from your comment, uncomment and change some code for openldap, so how about other *ldap implement?

Fixed

Assignee

Ray Lee

Reporter

Ray Lee

Labels

None

Tested By

None

Components

Priority

Major