Bug Completing Bank Statements when using calendar & accounting periods per org: A potential wrong/test validation for open period is being performed in the class: BankStatement

Description

With a Idempeire 3.1 environment, where we defined calendar & accouting periods per organization (not at client level only as usual) During the process to complete a bank statement for an specific organization (not *) , all the time Idempiere 3.1 is showing the message : Close period though the periods are open.

Checking the current source code Plugin: org.adempiere.base, Class: org.compiere.model.MBankStatement, we see a couple of lines (330 and 331) , that are sending all the time the organization as 0.

330 - MPeriod.testPeriodOpen(getCtx(), minDate, MDocType.DOCBASETYPE_BankStatement, 0);
331 MPeriod.testPeriodOpen(getCtx(), maxDate, MDocType.DOCBASETYPE_BankStatement, 0);

So for scenarios where the calendar & accounting periods are created for specific organizations (not for *), these validations are failing always .. a quick fix, would be to send the current org or to remove the validation perhaps right ?

Environment

Centos Linux 64bits. Postgres 9.4 Idempiere 3.1

Activity

Show:
Norbert Bede
July 6, 2016, 5:02 PM

hi, as i know bank statement has no doctype, required for proper validation. would be nice implement doctype.
norbert

Assignee

Carlos Ruiz

Reporter

Pedro Rozo

Labels

None

Tested By

None

Components

Affects versions

Priority

Blocker
Configure