Infowindow:Previous recordSelectedData don't clear before process run

Description

Step-byStep:
1) We selected 2 records
2) We run some process
3) We selected another 3 records
4) We run the same process again
5) Process did 5 records (2+3) and selected 5 records in infowindow
This is mistake!

Solution:
We added one line to package org.adempiere.webui.panel.InfoPanel.InfoPanel

updateListSelected(){
+ recordSelectedData.clear();
...
}

Environment

None

Activity

Show:
Hiep Lq
June 8, 2016, 11:32 PM

Hi , remember selection is old behavior, i just want remain it when development "remember selection during pagination"
configurable is ok. make it flexible.

about your concern about sync selection after run process.
yes, records is refresh after running process.
for new insert record, it out of selection, because we manual select, it's issue when we choose by filter (define some category to filter).
for update and delete record, it's ok if we don't change viewID column, just get trouble when change viewID column
other big issue, we have to implement function syncSelectedAfterRequery. i not yet implement it by worry about performance.
current each time refresh records, just current page and some buffer page is loaded, if sync selection, maybe have to load all result record.

just think about new way to sync selection, just compare key of all result record, so not need load complete record, just viewKey data, so performance can acceptable.

i still curious how can redo his issue after my patch, it's importance to improve code to cover all case.

Peter Shepetko
June 10, 2016, 5:46 AM

Hi Carlos Antonio Ruiz Gomez and hieplq,
I agree that selection during pagination is a nice improvement.
I will test it and I will answer about it.

Peter

Hiep Lq
June 11, 2016, 8:53 AM
redhuan d. oon
December 6, 2017, 9:49 PM
Edited

I tried to tell this same issue i have before and now i understand why. It is preserved for pagination. It is kind of intermittent. I made a point to refresh few times to make sure they are cleared.

redhuan d. oon
December 7, 2017, 12:02 AM

I think the old features of remembering is good. What is left to do is allow Refresh button to clear after process. Or a 'Save Selection' flag checkbox. With that off or on it is obvious.

Assignee

Hiep Lq

Reporter

Peter Shepetko

Labels

Tested By

None

Affects versions

Priority

Critical
Configure