improve set of max text lenght on grid panel

Description

The max length of a text in grid view is limited by default to 60 character in the class GridTabRowRenderer.java by the variable MAX_TEXT_LENGTH. This value could be customizable by a System Variable to make the theme more flexible when customizing the zk

Environment

None

Activity

Show:
Carlos Ruiz
May 9, 2016, 2:45 AM

Thanks

I think the name of the SysConfig must be more clear - just saying MAX_TEXT_LENGTH would be very misleading for people configuring.

I suggest something like MAX_TEXT_LENGTH_ON_GRID_VIEW - and make this SysConfig client wide, so would be something like:

MAX_TEXT_LENGTH = MSysConfig.getIntValue("MAX_TEXT_LENGTH_ON_GRID_VIEW", 60, Env.getAD_Client_ID...

For this we need a migration script that creates the initial sysconfig value with client level on database.

Regards,

Carlos Ruiz

Dirk Niemeyer
May 20, 2016, 7:57 PM

Hi , hi ,

I have slightly modified the code following the recommendation from Carlos and created an entry in MSysConfig.
I do not think that an initial sysconfig value is necessary. Adding an entry in the wiki page http://wiki.idempiere.org/en/System_Configurator_(Window_ID-50006) should be sufficient. WDYT?
Regards,
Dirk Niemeyer

Carlos Ruiz
May 20, 2016, 9:30 PM

Thanks

For sysconfig at system level is ok, but as this sysconfig is at tenant level I think is better to have the initial record set with the proper level, not having that record can lead to problems in implementations.

Regards,

Carlos Ruiz

Dirk Niemeyer
May 23, 2016, 3:21 PM

Hi ,

thank you for the recommendation. I was not aware of the checking in MSysConfig.beforeSave. The corresponding migration sccripts are attached.

Regards,

Dirk Niemeyer

Norbert Bede
April 9, 2018, 7:57 PM

Assignee

Eduardo Gil

Reporter

Angel Lara

Labels

Tested By

None

Components

Affects versions

Priority

Minor
Configure