Add IBAN and Swift fields to Business Partner/Bank Account

Description

C_BP_BankAccount has basic information for handling business partner bank accounts. However, it is missing two fields from c_bankaccount that are important for international transactions: IBAN and SWIFT. I've attached the migration scripts to add them

Environment

Clean Virtual Appliance

Activity

Show:
Markus Bozem
January 16, 2017, 2:00 PM

Bugfixes to model and swing client data.

Markus Bozem
January 14, 2017, 6:08 PM

I extended the patch and added the new columns to the data model and business logic

Markus Bozem
January 14, 2017, 2:53 PM

I attached a patch to do the following:

Add columns to tables:

IBAN to c_pb_bankaccount
IBAN and SWIFTCODE to c_payment
IBAN and SWIFTCODE to i_payment
IBAN and SWIFTCODE to c_pospayment
IBAN and SWIFTCODE to c_paymenttransaction

No changes to views

Add fields to windows

IBAN to c_pb_bankaccount
IBAN and SWIFTCODE to c_payment
IBAN and SWIFTCODE to c_pospayment
IBAN and SWIFTCODE to i_payment (Import Payments)
IBAN and SWIFTCODE to c_paymenttransaction

Markus Bozem
January 10, 2017, 3:45 PM

After a day investigating, my opinion is:

1) @Nicolas Micoud: Your are right, there should be a IBAN column and where necessary a BIC/SWIFTCODE column.

2) The current patch adds IBAN and SWIFT to c_pb_bankaccount, but i´m not sure if SWIFTCODE is necessary because bank is in c_pb_bankaccount a mandatory field and refers to c_bank and theres a SWIFTCODE.

3) IBAN and SWIFTCODE should also be added to c_payment

4) I am not shure if: IBAN and SWIFTCODE should also be added to i_payment

5) I am not shure if: IBAN and SWIFTCODE should also be added to c_pospayment

when its clear what fields are needed, i would generate new migration scripts an attach them to this issue.

Thanks,

Markus.

Nicolas Micoud
January 10, 2017, 7:58 AM

Hi all,
I don't think using AccountNo is a good option (not a good idea to use a column for another purpose).
The easier way is to add the IBAN column. And then people can use it or not.
WDYT ?

Thanks,

Nicolas

Fixed
Your pinned fields
Click on the next to a field label to start pinning.

Assignee

Markus Bozem

Reporter

Antoni Ten Monrós