Attribute, Table Direct and date field support

Description

this patch improve attributes with new type
1. Table Direct
2. Date

users will able to refer from attributes to tables and define custom date.

Environment

None

Activity

Show:
Deepak Pansheriya
December 1, 2020, 8:44 AM

as per your feedback, PR created to fix it.

Carlos Ruiz
November 25, 2020, 9:59 AM

Reopening as there is a recommendation from that needs to be reviewed:
https://github.com/idempiere/idempiere/pull/403#discussion_r528327514

Going through the history, this originated from the changes for IDEMPIERE-2999. While the code works fine (including this fix), it is not tidy design wise.
1. You really want to take a KeyNamePair, not int valueInt + String value parameter that's hard to understand.
2. MAttributeInstance have getValueInt and setValueInt pair that doesn't follows common Java Bean rule and kind of confusing.
3. MAttributeInstance should have a constructor that take KeyNamePair (or valueInt + value for the current implementation). The lack of that constructor make it inconsistent with other part of the code.

Deepak Pansheriya
October 26, 2020, 11:56 AM
Edited

@Cruiz understood. I reviewed and approved your PR yesterday. Do merging required manually or it needs Hengsin approval?

Carlos Ruiz
October 26, 2020, 11:24 AM

, in your test case it says:

> Login with System role

Creating such things with System role, or with an Advanced Role is OK. Advanced Roles have basically the keys of the server (same as System).

Which is unacceptable on security terms is allowing a non-advanced role (an end user) to be able to configure that thing.

This possibility was opened because of this ticket.

Regards,

Carlos Ruiz

Deepak Pansheriya
October 25, 2020, 9:39 AM

I suggest to create new bug

Fixed
Your pinned fields
Click on the next to a field label to start pinning.

Assignee

Deepak Pansheriya

Reporter

Norbert Bede

Labels