Import Payment imports from multiple clients

Description

  • In the ImportPayment.java, clientcheck is added to avoid queries updating the import records of other client. So there is an issue where i.I_isImported<>'Y' OR i.I_isImported IS NULL is not enclosed in brackets so entire queries after OR is executed as OR condition.

  • Also there is no clientcheck in the query to get the ImportPayment records which are not imported, so currently it brings all the records from all the clients.

Please find attached patch for the same.

Environment

None

Activity

Show:
Carlos Ruiz
October 14, 2015, 2:09 PM

Thanks , reviewing the code I see same issue is spread in many of the Import classes

I see other "OR" not between parenthesis in the class in (r2.1) lines 126, 143
Similar issues in ImportGLJournal and others.

Developer question: if you want to be mentioned as developer in the commit message can you please give me your bitbucket user - or your preferred developer info for the commit message - alternatively you can upload your patch complete, some developers do something like:
hg commit (fill developer and commit message - commit message must mention the JIRA ticket)
hg export (export the changeset just committed)
hg rollback (to clean the local commit)

Regards,

Carlos Ruiz

Carlos Ruiz
October 14, 2015, 2:20 PM

BTW - importing payments maybe is easier with the new CSV Importer - we're probably deprecating old importers

Pritesh Shah
October 16, 2015, 8:34 AM

I have uploaded new patch with some info as requested, can you please verify those so from next time I will take care of those?
Also, new CSV Importer will import child tab records similar to Window Import import functionality with single file?

Carlos Ruiz
October 16, 2015, 1:21 PM

> Also, new CSV Importer will import child tab records similar to Window Import import functionality with single file?

Yes, please check http://wiki.idempiere.org/en/NF1.0_ImportCSV

Assignee

Pritesh Shah

Reporter

Pritesh Shah

Labels

Tested By

None

Fix versions

Affects versions

Priority

Major
Configure