Cant confirm 0 qty on Movement Confirmation

Description

problem: stockeeper sometimes cant found physically goods when moving material with Inv. Move. In this case user must confirm 0 qty. Actually user able decrease qty to less then target but minimally to 1.

steps
1. setup: im doctype - set to Transit
2. create inv. move, complete it
3. open confirmation, confirm 0 >> BUG

see attached screenshot

Environment

None

Activity

Show:
Hiep Lq
May 18, 2015, 1:57 AM

seem inventory move confirm copy from shipment confirm but don't complete.
as help infor, scrappedQty is for QC process, but inventory move don't have this process.

after confirm, move line will fill with confirm value.
have two where for consider.
1. at MMovementLineConfirm
current: moveline.moveQty = confirmLine.confirmQty
maybe it change to moveline.moveQty = moveline.moveQty - confirmLine.scrappedQty

2. at MMovementLine.beforeSave
add condition to by pass when (moveline.moveQty = 0 and confirmLine.scrappedQty > 0)

(1) change current logic, i don't sure current logic is correct and also don't sure what i suggest is correct.
(2) i feel scrappedQty is don't complete implement because maybe total remove it.

Norbert Bede
May 18, 2015, 7:00 AM

pls follow up, then we implement it well.

Orlando Curieles
June 3, 2016, 10:06 PM

I commented this lines to test:
if (getMovementQty().signum() == 0)
{
if ( MMovement.DOCACTION_Void.equals(getParent().getDocAction())
&& ( MMovement.DOCSTATUS_Drafted.equals(getParent().getDocStatus())

MMovement.DOCSTATUS_Invalid.equals(getParent().getDocStatus())

MMovement.DOCSTATUS_InProgress.equals(getParent().getDocStatus())

MMovement.DOCSTATUS_Approved.equals(getParent().getDocStatus())

MMovement.DOCSTATUS_NotApproved.equals(getParent().getDocStatus())
)
)

{
// [ 2092198 ] Error voiding an Inventory Move - globalqss
// zero allowed in this case (action Void and status Draft)
} else {
log.saveError("FillMandatory", Msg.getElement(getCtx(), "MovementQty"));
return false;
}
}

And allow 0 qty on inventory movement, but I see something dangerous, the move confirm process create automatically a movement inventory with the differences, subtracting the qty not confirmed. I think is better create a movement inventory to another warehouse ( maybe a transit warehouse or lost product warehouse ) to make a revision of that.

WDYT ?

Regards.

Carlos Ruiz
July 30, 2020, 8:17 PM

Confirmed, created pull request https://github.com/idempiere/idempiere/pull/198

Carlos Ruiz
July 30, 2020, 8:18 PM

BTW - about the comment from , the confirmation creates an inventory move marking those items as "inventory out" (lost I guess) for review.

Assignee

Carlos Ruiz

Reporter

Norbert Bede

Labels

Tested By

None

Priority

Major
Configure