improve method to add comment to log script

Description

almost time i create migrate script without comment (exact use default comment, very wrong context)
this ticket will help lazy man as me.

Environment

None

Attachments

4

Activity

Show:

Carlos Ruiz May 20, 2020 at 6:50 PM

Carlos Ruiz May 19, 2020 at 10:19 PM

Hi , please check pull request 75

With this I implemented your idea here, it works like this:

  • first you must set Log Migration Script flag and Save

  • then when you open again the preference the field "Migration Script Comments" appear

Carlos Ruiz May 25, 2015 at 11:46 PM

Now that is solved, maybe is worthy to make this an extension?

Hiep Lq March 20, 2015 at 2:12 PM

it let config idempiere more modem than manual change in system configuration window
1. each user preference is a no-go (like the old info windows).
maybe please sent me a picture of "old info windows"

2. "The preference link in the header could show the quick entry fields of this new window, and an "Advanced" link to open the window."

hear as quick setting of blackberry 10
it seem as extends system config to user level, and let user can change it visual than access system configuration window.
about detail i will like discus at next weekly meeting.

Carlos Ruiz March 19, 2015 at 2:36 PM

Indeed, more than pluggable I think is really worthy to have a user preferences window configurable (via a properties or via dictionary) - changing the WPreference class for each user preference is a no-go (like the old info windows).

I have thought also if we create a table/window AD_PreferenceForm based on the usual dictionary and via model validators and callouts we load and change the corresponding value on AD_Preference (or maybe change the code to read from the new table?)

The preference link in the header could show the quick entry fields of this new window, and an "Advanced" link to open the window.

WDYT?

Hiep Lq March 19, 2015 at 7:03 AM

i know Query can get MSysConfig object, but it's common to has get method in po class, because i add it to MSysConfig
about add ability extensible i worry it duplicate with IDEMPIERE-2000?

Carlos Ruiz March 18, 2015 at 8:17 PM

, I reviewed the patch and I think the modification to MSysConfig is not needed, uploading a patch IDEMPIERE-2523_alt.patch suggesting using Query to get the MSysConfig object.

Now, instead of this patch I think it can be worthy to work on making WPreference extensible (or pluggable). I think this is one of the things that every implementation would like to add their own preferences for users.

WDYT?

Hiep Lq March 15, 2015 at 7:03 PM

below is logic implement:
default comment is "I forgot to set the DICTIONARY_ID_COMMENTS System Configurator"
when load popup if DICTIONARY_ID_COMMENTS same default, set value of textbox is blank other, load current value

when push save button if checkbox is check
if textbox is blank, save value as default
other set value in textbox

Fixed

Details

Assignee

Reporter

Labels

Components

Fix versions

Priority

Created March 15, 2015 at 4:10 PM
Updated August 6, 2021 at 11:47 AM
Resolved May 20, 2020 at 2:44 PM