Add SysConfig keys to avoid using hardcoded values on login page
Description
Environment
Attachments
- 23 Oct 2014, 08:35 AM
- 23 Oct 2014, 08:33 AM
- 23 Oct 2014, 08:21 AM
- 23 Oct 2014, 08:21 AM
- 23 Oct 2014, 08:21 AM
- 22 Oct 2014, 08:09 AM
- 22 Oct 2014, 08:09 AM
- 22 Oct 2014, 08:09 AM
- 22 Oct 2014, 08:09 AM
- 22 Oct 2014, 08:09 AM
- 22 Oct 2014, 08:09 AM
Activity
Jan Thielemann October 23, 2014 at 8:41 AM
Will this be integrated into the trunk? If yes, we should make a wiki page in the new features section
Jan Thielemann October 23, 2014 at 8:35 AM
Also added a check that if nothing is there to display, the blue box is not displayed at all
Jan Thielemann October 23, 2014 at 8:24 AM
Now it is solved like this:
1. Check if the system is production system
1.1 If yes, default for isShown for DB version, Host, OS and JVM is false
1.2 If no (system is evaluation or implementation), every value is shown by default
2. Check if there is a _SHOWN key in sysconfig
2.1 If yes, use the sysconfig value to determine if a value is shown
2.2 If no, use the default value to determine if a value is shown
3. For every shown value check if there is a sysconfig key (e. g. APPLICATION_MAIN_VERSION)
3.1 If there is a key, use this key
3.2 If there is not a key, use the default value (e. g. read version from bundle instead of sysconfig)
Nicolas Micoud October 22, 2014 at 5:33 PM
Checking AD_System.SystemStatus could be the default behaviour, but it can be overwritten by a sysconfig key ? And wondering if we should add more stuff about the vendor (location, phone, ...)
Carlos Ruiz October 22, 2014 at 3:29 PM
Wondering if we can check AD_System.SystemStatus - if is in production then we just show the Vendor Information - and vendor information can be sysconfigurable as proposed.
Following https://groups.google.com/d/msg/idempiere/SoPeqW96lUk/vE7Vs07YkYQJ
The idea is to add sysconfig keys to be able to avoid using hardcoded values (like program version, vendor, ...)