That correspond directly to the name and print name field. Will check why changes make is not working.

Hi,

Just make a quick test and I’m wondering why there is the interest to have Name and PrintName fields on the editor.
I’ve updated the content and see no change (neither on the graphical part or in the PrintFormatItem tab.
DId I miss something ?

Regards,

Nicolas

Perhaps we can add a warning to the sys config entry that 16 is not fully tested and might create inconsistency in application

Agree, but ZK_TOOLBAR_BUTTON_SIZE is not a SysConfig, is a context variable set in preference.zul - I think is not documented anywhere so I doubt anybody is really using that.

Hi ,

• will check the restore issue

• yes, better to commit those maven stuffs.

• will check those nature issue

• I’ve forgotten about that. the Action interface doesn’t cater for that and I think the 16 pixel option is not well tested. Perhaps we can add a warning to the sys config entry that 16 is not fully tested and might create inconsistency in application.

Regards,

Low

Hi

I tested this one successfully and pushed it to master.

Some minor issues found:

• The editor is opened in maximized mode, when I click on the “Restore” button, the window disappears, just the title is shown and the resulting window is not resizable

• I was able to make it work importing the new project in eclipse as maven project. But it pushed some changes to org.idempiere.printformat.editor/.project adding the maven nature and buildCommand

• It also added the files org.idempiere.printformat.editor/.settings/org.eclipse.core.resources.prefs and org.idempiere.printformat.editor/.settings/org.eclipse.m2e.core.prefs

• Maybe would be better to have those files committed so there are no changes in the project when integrated?

• There is also a warning in eclipse in the .project → Unknown referenced <nature>com.jaspersoft.studio.babel.editor.rbeNature</nature>

• Unrelated to this ticket but I have the same warning on base with → Unknown referenced <nature>org.eclipse.xtext.ui.shared.xtextNature</nature>

• This is not from this ticket, but in general from the implementation of Action plugins: when configured in a theme to use ZK_TOOLBAR_BUTTON_SIZE = 16 - all the toolbar buttons appear with size 16, but the action button of this plugin appears with size 24 - and also I noticed there are many places in the code where size 24 buttons are shown instead of 16 (maybe would be simpler to deprecate the support of those “16pixel” icons?)

Regards,

Carlos Ruiz