C_InvoiceLine values for TaxAmt and LineTotalAmt wrong in some cases

Hi,

I just ran into this same issue today with Purchase Invoice with List price IsTaxIncluded ='Y'.

So, still present in iDempiere 8.2

Hi Carlos,

reason is AFAICS line 700 in CalloutInvoice

mTab.setValue("LineTotalAmt", LineNetAmt.add(TaxAmt));

There the correctly calculated TaxAmt is added even if it’s already included in LineNetAmt.
I think replacing it with

if (isTaxIncluded(WindowNo))
{
mTab.setValue("LineTotalAmt", LineNetAmt.add(TaxAmt));
}
else
{
mTab.setValue("LineTotalAmt", LineNetAmt);
}

would do the job.

Regards,
Martin

More research on this.

• there is a test case when price include tax - and user change the default tax on the line (the default get from the product), then there is a recalculation of the line amount (which in my opinion is wrong)
  This was integrated on ticket https://sourceforge.net/p/adempiere/bugs/600/
  Commit https://bitbucket.org/idempiere/idempiere/commits/f55b238
  IMHO if the price list says that includes tax - then the buyer expects that the price listed is what is charged - changing the tax must not affect the end price of the order, it must affect just the tax calculation, but the price must be preserved.
  Now, that code just work if the tax is not document level - for document level taxes it keeps working as I mentioned.

• Another "issue" found - but it makes sense - if the tax is set as Document Level tax - then the taxamt on lines is not filled, you must read it from C_OrderTax in such case and is not associated to a specific line.

New note, seems like C_InvoiceTax is also wrong - using "Price List Include Tax" makes the taxes on report "Invoice Detail & Margin" useless.