Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Remove PREFERENCETYPE_AD_Reference_ID in generated X_ class

Description

Now the generated X_ class will have hardcoded PREFERENCETYPE_AD_Reference_ID.

This is not used, just don't generate it or change to better way (no hardcode)

Environment

None

Activity

Show:

Carlos Ruiz April 30, 2013 at 10:34 PM

This can be specially dangerous for custom classes - references would be pointing to non-official IDs (>1000000) and it would be a big mistake to use it as the ID can be different in another implementation.

Ken Longnan April 27, 2013 at 9:06 AM

Yes and No.

Actually I mean "public static final int PRODUCTTYPE_AD_Reference_ID=270;" in X_M_Product.java, but they are related.

For both of them, I just feel bad smell.

Now another topic popup, how can we manage/control the AD changes and generated X_ class in a better osgi way? I mean AD changes and X_ class they are much tight binding each other, looking for one kind of mechanism to process.

BR,

Ken

Heng Sin Low April 27, 2013 at 7:08 AM

Hi, do you means like " public static final String PRODUCTTYPE_Item = "I"; " in X_M_Product.java ?

Fixed

Details

Assignee

Reporter

Priority

Created June 14, 2012 at 9:40 PM
Updated May 2, 2014 at 9:57 PM
Resolved December 18, 2013 at 3:19 PM