Pull the promotions out of the trunk. Leave it as a plugin

Hi - I added a pull request in your plugin and a pull request in core

After this is integrated we will have two more pending things:

• Migration Note explaining what to do for the people that can be affected by the change - f.e. those using promotions and having it registered as a ModelValidator - or anybody using MOrder.getM_Promotion_ID() in code

• Create an Available Plugins new page documenting this plugin

As usual, your tests and feedback will be appreciated.

For testers / peer reviewers:

• I changed the entity type from Dictionary to Extension in all the menus, windows, tabs, fields, tables, columns, index, and index-columns related to promotions.

• I added a migration script to include some changes that had in the old 2Pack

• The migration script change the entity type and inactivate all those records

• The 2Pack_1.0.0 was deleted from the plugin as it was obsolete and causing damage on the dictionary (f.e. restoring Client instead of Tenant as terminology)

• Added the 2Pack_2.0.0 that reactivate all the records required for promotions

Regards,

Carlos Ruiz

Hello, I’ve solved this issue in this plugin:
You can check, and mark as resolved.
Regards

Triaged by Diego Ruiz,

I think it is still worth it to remove this from the core. Heng Sin worked in a ticket related to this not so long ago, where he removed many plugins from the core.

agreed:

Yes, I think that's a good move. Using AD_ModelValidator does have its advantage - it can be make tenant configurable.