'Generate PO From Sales Order' function and 'deliveryviarule' field inconsistencies
Description
Environment
ubuntu 14.04 LTS
Attachments
Activity
RedhuanO April 22, 2015 at 4:12 AM
Sorry Carlos Ruiz, you are right, Drop Ship was not mentioned even in patch but was assumed. Thank you for your kind patience. Only when looking at the whole method it is evident:
Carlos Ruiz April 21, 2015 at 8:38 PM
Ah sorry - my fault - I think patch is ok - let me test it
Jason Martin April 21, 2015 at 8:35 PM
Thank you Carlos. Question then, would this fix for Drop Ship SO DeliveryVia to carry over to PO from "Generate PO from SO" be logical to add to core? Just for Drop Ship only.
Carlos Ruiz April 21, 2015 at 8:28 PM
Thanks , the description didn't mention it's for drop shipment and the patch is also beyond dropship as I see. I think for dropship can make sense what you suggest.
Jason Martin April 21, 2015 at 8:22 PM
Redhuan or Carlos, could you elaborate on your thoughts as to why SO and PO DeliveryVia could be different on a Drop Shipment? Here is my thought on the matter, if a SO is created as a Drop Ship then the customer may have dictated a specific shipper that they want used, or a specific shipping account would need to be used based on special rates that have been negotiated, just some possible scenarios. If that is not carried through to the PO then the Drop Ship vendor has no record of that. To have the default set to "Pickup" or any other method and the SO DeliveryVia not carried to the PO would seem troublesome to me, IMHO. Any input is appreciated.
For example, if we create a Sales Order with Delivery Via (deliveryviarule) set to 'Shipper', then we use that SO to create a PO (by 'Generate PO From Sales Order' function), then we see that the PO now has its deliveryviarule field set to 'Pickup'. It seems like this should instead carry over the deliveryviarule value from the SO to the PO, and I wonder if just some code should be added to the OrderPOCreate class to make this happen, or if there was a business reason to not do so...?