Atlassian uses cookies to improve your browsing experience, perform analytics and research, and conduct advertising. Accept all cookies to indicate that you agree to our use of cookies on your device. Atlassian cookies and tracking notice, (opens new window)
i am playing little bit with Replication feature. I notices that there is one major bug related to model validator - model validator on Client is registered to validation engine multiple times instead of once. I think this is not bug in Implementation of ExportModelValidator, but ModelValidatorEngine, because it looks like model validators are not removed from validation engine when user changes role or log out, but when user is logged again. validator is registers again too.
Steps to reproduce: 1. In Client window set org.adempiere.ExportModelValidator as model validation class 2. Rester your server to apply this change 3. Login into system 4. Change role and log in with same credentials
These steps cause that one Model Validator is registered multiple times in Model Validation Engine and modelChange method is executed multiple times = BUG.
Bug can be also seen when you try to debug addModelChange method of ModelValidationEngine class.
Environment
None
Attachments
1
10 Dec 2014, 12:00 AM
Activity
Show:
Daniel Tamm December 27, 2014 at 11:24 AM
Thanks for catching and fixing this Had the same problem in my replication setup... after a while the ExportModelValidator was registered so many times I had to restart everything not to choke the JMS topic with lots of duplicate messages. I'm very happy for the fix Great work!
Tomáš Švikruha December 25, 2014 at 5:05 PM
I've not found any other issues, so I think yes
Carlos Ruiz December 23, 2014 at 8:53 PM
@Tomáš Švikruha, how is this going? ready to be integrated?
Tomáš Švikruha December 10, 2014 at 7:19 AM
Edited
I will continue with testing and if there will be some new issues/bugs I will let you know.
@Carlos Ruiz Thanks for your time
Carlos Ruiz December 10, 2014 at 12:00 AM
ok @Tomáš Švikruha, third version hope third time's a charm
Hi,
i am playing little bit with Replication feature. I notices that there is one major bug related to model validator - model validator on Client is registered to validation engine multiple times instead of once. I think this is not bug in Implementation of ExportModelValidator, but ModelValidatorEngine, because it looks like model validators are not removed from validation engine when user changes role or log out, but when user is logged again. validator is registers again too.
Steps to reproduce:
1. In Client window set org.adempiere.ExportModelValidator as model validation class
2. Rester your server to apply this change
3. Login into system
4. Change role and log in with same credentials
These steps cause that one Model Validator is registered multiple times in Model Validation Engine and modelChange method is executed multiple times = BUG.
Bug can be also seen when you try to debug addModelChange method of ModelValidationEngine class.