Performance tuning: Remove use of echo event for the opening of new window
Activity

Heng Sin Low July 3, 2014 at 12:48 PM
Please open another ticket for that ( AFAIR, the sizing of the iFrame is not consistent without the echo. )

Hiep Lq July 3, 2014 at 9:14 AM
you can review my case https://groups.google.com/forum/#!topic/idempiere/3HJkRTdqGqU
it's same.
my patch is working very good for long time
HG changeset patch
User hieplq
Date 1404129032 -25200
Branch hsv
Node ID f9295245f3970e4f2f27fcdb59bc782179959ec8
Parent bf9d7a54289475a8da89d4c939c351c92da46d47
hsvonly:Why ZkJRViewer embed report at a echoEvent?
refer: https://groups.google.com/forum/#!topic/idempiere/3HJkRTdqGqU
diff --git a/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/window/ZkJRViewer.java b/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/window/ZkJRViewer.java
— a/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/window/ZkJRViewer.java
+++ b/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/window/ZkJRViewer.java
@@ -297,8 +297,7 @@
Thread.currentThread().setContextClassLoader(cl);
}
- iframe.setSrc(null);
- Events.echoEvent("onRenderReport", this, null);
+ iframe.setContent(media);
}
private File getPDF() throws IOException, JRException {
@@ -318,10 +317,6 @@
return file;
}
- public void onRenderReport() {
- iframe.setContent(media);
- }
-
@Override
public void onClose(Tabpanel tabPanel) {
Tab tab = tabPanel.getLinkedTab();
Details
Details
Assignee

Reporter

Opening of new window:
1. Remove the use of echo event that will cause an extra network round trip.
2. Add defer rendering to the content area of ad window.