Adding functionality to add charts on the standard windows.
Description
Environment
Attachments
- 17 Jul 2013, 02:05 PM
- 17 Jul 2013, 02:05 PM
relates to
Activity
Carlos Ruiz July 17, 2013 at 2:42 PM
Thanks Deepak, some light peer review (not thorough, not tested):
the changes to AD_Field_V and AD_Field_VT must be on migration script too
new classes don't have GPL Header - maybe better we ask Adaxa to add GPL Header crediting them properly as contributor
adding a new field type we need to check the impact on:
DefaultLookupFactory.isLookup
DisplayType.isID
DisplayType.getDescription
MColumn.getReferenceTableName
Saw two concerning issues on the patch to check for potential issues:
what's the impact of line 3690 on GridTable which says?
// todo: temporary fix for carlos assumption that all windows have _id column
I see there can be an issue for tables which ID is <> than table_ID - but I think this needs to be reported and solved properly (maybe is just to change the table_ID by the getKeyColumn
we need to check carefully the impact of the change on AbstractADWindowContent
don't get at first sight the meaning of that change (is it related to this ticket?), and maybe it can impact other features (like passing the where clause to the reports)
Regards,
Carlos Ruiz
Deepak Pansheriya July 17, 2013 at 2:05 PM
Attached are the patches containing changes to add chart functionality.
Facility to draw a chart on any standard window by defining a field on the tab. A chart is to be defined on the chart window and it will be configurable as a column of chart data-type.