Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Performance: avoid loop in X_ class interface getters

Description

The call to interface getters in X_ classes are using tablename, for example:

the idea is to change it to use Table_ID instead, this way travelling the loop in the cache is avoided, like:

Environment

None

Activity

Show:

Nicolas Micoud September 14, 2021 at 12:46 PM

Thanks

Heng Sin Low September 14, 2021 at 12:40 PM

Hi ,

Yes, that should perform better.

On the other hand, we do have another PR - that would warrants the regeneration of all model classes.

Regards,

Low

Carlos Ruiz September 14, 2021 at 12:35 PM

Yes - that must work with non-core tables too - the non-core I_ classes don’t sent the Table_ID directly but calling MTable.getTable_ID

That was one of the first things that I fixed in the project in 2006

Nicolas Micoud September 14, 2021 at 12:27 PM

Hi,

I haven’t tested but can it be used for non core tables too ?
As those tables won’t have the same AD_Table_ID, that won’t work or am I missing something ?

Regards,

Nicolas

Carlos Ruiz September 14, 2021 at 12:25 PM

Hi - can you please check the pull request 880

I just generated the model classes for AD_PInstance_Para, but if you think is good I can run it for all tables in a second commit.

Regards,

Carlos Ruiz

Fixed

Details

Assignee

Reporter

Fix versions

Priority

Created September 14, 2021 at 12:22 PM
Updated November 1, 2021 at 8:19 PM
Resolved September 14, 2021 at 1:27 PM