Attached two files:
- your patch converted to version 6.1z
- a small peer review from my side:
fixing the name of migration script (yyyymmdd)
fixing the oracle migration script (it was different than postgres version)
creating the sysconfig key and changing it to client scope
I'm not sure if is good to have the field style for the whole line instead of individual cells. Maybe field style would go better to AD_InfoColumn?
Also, on the summary, what I expected is to show the summary of a column, but I noticed is showing the summary just for selected records. That sounds useful for some cases, but I think what would be expected is the total of a column, maybe as an additional line showing totals (in case more than one column is totalized).
For the piece implementing opening forms from info window process - maybe we can integrate that to 6.1 in a different ticket - sounds like a bug fix.
Attached a new patch for default branch with original code + review + changes suggested:
Summary and style on column:
On CSS Style we can use info window columns as variables:
Final result with sumaary on header for selection and on last line for total amt/qty for defined columns:
On future i will extend the summary function to work in a similar way of "PrintDataGroup" letting users select more operations than only sum, but for now i think that this is enought and usefull.
I was reviewing this.
My old patches are obsolete, so I uploaded fresher patches:
I could not review your new patch
When downloaded it's downloading a patch from ticket - could be problem with JIRA or maybe you uploaded wrong patch?
sorry, it was my mistake… i'll check it later and attach an updated patch here
Here you can find a newer patch with a different implementation for info column style.
An usage example on some BPartner Info columns:
This is the dictionary definition:
CSS Style uses Info Columns “ColumnName” field as context variables for conditional:
NOTE: I'm working o a better implementation for summary fields (and other operations) for info windows. I'll keep this out of this patch for now, and when it's ready i'll open another ticket (as you suggested some time ago).