ITaxProvider - Do not recalculate tax for docline when it is processed

Description

MOrderLine.afterSave() always calls ITaxProvider.recalculateTax() even when processing shipments/invoices (due to changes in reserved/delivered/invoiced fields). Althought being simple to work around this behavior (checking isProcessed in recalculateTax() and just returning), it not seems to be consistent this call to the method.

What about adding !isProcessed() before trying to recalculte taxes?

Attached is suggestion patch for MOrderLine/MInvoiceLine/MRMALine

Environment

None

Activity

Show:
Alan Lescano
March 8, 2014, 4:36 PM
Edited

The patch resolve when processing shipments/invoices, but doesn't resolve the call to recalculateTax() when preparing order and qty of line was changed - due to changing reserved qty field.

MarcoL
August 22, 2020, 11:48 AM

triaging Marco Longo

MarcoL
August 22, 2020, 11:52 AM

Not clear whatis the problem . Please Alan show example to reproduce

thanks

Assignee

Unassigned

Reporter

Alan Lescano

Tested By

None

Priority

Major
Configure