Description
Environment
Attachments
- 16 Oct 2015, 08:33 AM
Activity
Carlos Ruiz October 16, 2015 at 1:21 PM
Pritesh Shah October 16, 2015 at 8:34 AM
I have uploaded new patch with some info as requested, can you please verify those so from next time I will take care of those?
Also, new CSV Importer will import child tab records similar to Window Import import functionality with single file?
Carlos Ruiz October 14, 2015 at 2:20 PM
BTW - importing payments maybe is easier with the new CSV Importer - we're probably deprecating old importers
Carlos Ruiz October 14, 2015 at 2:09 PM
Thanks @Pritesh Shah, reviewing the code I see same issue is spread in many of the Import classes
I see other "OR" not between parenthesis in the class in (r2.1) lines 126, 143
Similar issues in ImportGLJournal and others.
Developer question: if you want to be mentioned as developer in the commit message can you please give me your bitbucket user - or your preferred developer info for the commit message - alternatively you can upload your patch complete, some developers do something like:
hg commit (fill developer and commit message - commit message must mention the JIRA ticket)
hg export (export the changeset just committed)
hg rollback (to clean the local commit)
Regards,
Carlos Ruiz
> Also, new CSV Importer will import child tab records similar to Window Import import functionality with single file?
Yes, please check http://wiki.idempiere.org/en/NF1.0_ImportCSV