Error with taxes and country groups

Pull request 1186

We were hit by the same issue mentioned by @Martin Schönbeck here:
https://groups.google.com/g/idempiere/c/yvr64BakfSs/m/qd55RKLbCgAJ

To configure the taxes for a product so:

Germany → Germany = 19%
Germany → European Union = 0% identifiable as Intra-EU
Germany → Rest of the world = 0% identifiable as Extra-EU

The actual code doesn’t work. As suggested by Martin there, allowing to enter the country next to the country group solves the issue.

I found this old patch suggested here, did the tests and is working fine for the German case (and I assume is the same for all the other EU countries). No need to exclude Germany from the country group.

Also, the patch is backward compatible, because it doesn’t touch the logic for the tax calculation at this moment, is just enabling to enter a more detailed record in tax rate.

Hi,
Closing this issue as it's working well on a 'fresh' new installation

Thanks @Nicolas Micoud, so the patch is incomplete, I'm dropping the label +Patch until a complete patch arrives.

Hi @Carlos Ruiz

I've done others tests and find out that the patch is working if France is not part of the Country group EU.

Your patch is good as it allows to define rules from region/country/country group to region/country/country group.
But I guess something must be done in MTax to handle those case (discussed in forum).

wdyt ?

I think our accountant is using country group.
But as it was done 3 years ago, I need to check and re-test it.

Keep you updated !